Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix governance tests when running on long running testnets #2781

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

mkoura
Copy link
Collaborator

@mkoura mkoura commented Nov 20, 2024

No description provided.

The @pytest.mark.testnets decorator was removed from the
test_guardrails method in the TestGovernanceGuardrails class.

The guardrails tests cannot currently run on testnets. We need to modify
the tests to not try to update the guardrails script on testnets.
Making sure the test can run without setting up governance first.
@mkoura mkoura requested a review from saratomaz as a code owner November 20, 2024 12:57
Raise a ValueError when attempting to get default governance on testnets.
This ensures that the function does not proceed with unsupported operations
on testnet environments.
@mkoura mkoura merged commit d86bce6 into master Nov 20, 2024
3 checks passed
@mkoura mkoura deleted the gov_testnet_tests branch November 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant